Skip to content

Do not substitute return values of constrained calls#111030

Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:fix110932
Jan 2, 2025
Merged

Do not substitute return values of constrained calls#111030
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:fix110932

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

Fixes #110932.

The constraint would need to be resolved first.

Cc @dotnet/ilc-contrib

Fixes dotnet#110932.

The constraint would need to be resolved first.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MichalStrehovsky MichalStrehovsky merged commit efdd299 into dotnet:main Jan 2, 2025
@MichalStrehovsky MichalStrehovsky deleted the fix110932 branch January 2, 2025 21:04
@hez2010

hez2010 commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

I think this needs to be backported?

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

I think this needs to be backported?

Is there anything else beyond what's in #110932 that makes this more severe? We don't backport all bug fixes, they need to be severe to even consider a backport.

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

/backport to release/9.0-staging

@github-actions github-actions Bot unlocked this conversation Mar 13, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13828189562

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NativeAOT: Usage of static virtual method from interface gets miscompiled as infinite loop

4 participants