uri-encode filename because of rfc6266 section-4.3#2245
Open
fuminori-ido-m wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
It is treated as URI-encoded already when filename contains '%' so that the when original filename contains '%' like
a-%61.txtthen it is converted toa-a.txtat server-side.Reason
According to RFC6266 section-4.3, filename should be uri-encoded in form-data while in dropzone.js FormData append part passes raw filename via _renameFile() as follows in src/dropzone.js:
Solution
This PR encode by encodeURIComponent() at _renameFile when renameFile hook is not defined.
(I didn't touch user-customized renameFile() so that user need to take care about '%' issue mentioned above.)