v0.12.2 Refactoring and enabling work#1310
Conversation
…ew_cc and complete define/implement refactoring.
|
@StefanL, this is again a preparatory PR like #1316. There are however some deprecation and code structure changes which I will motivate below: Separation of header definition files and functional implementation files is essential for forward declarations and negating recursive inclusion issues. Even without recursive inclusions, NOT separating the files becomes wieldy (especially with docstrings), and for many people like me, incredibly cumbersome to read. The header file should at it's best be easily understood at a glance and give an unfamiliar developer an overview of the purpose and structure of a class / struct / function, etc. The namespace and file structure hierarchy benefits by matching as closely as reasonable, thus helping unfamiliar developers understand the purpose of each domain at a glance, and find things easily. Individual API's under a namespace domain benefit by being a
I have flattened the "core/include/webview" folder root to "core/include".
I have changed all With the exception of |
This is primarily a housekeeping release aimed at code readability, maintainability and enabling work for upcoming enhancements.
It has a large diff footprint, but does not change existing functionality ensuring 100% backwards compatibility.
Changed
Fixed
navigateURL strings with leading or trailing whitespace, causing silent execution anomalies. URL strings are now automatically trimmed for Darwin.Deprecated
webview::webviewC++ API class naming is ambiguous for compilers and humans, sowebview_ccis now declared in the Global namespace and should be used instead.#include "webview/webview.h"is deprecated in favour of#include "webview.h".Depends on PR's