Files that changed from the base of the PR and between 0900610 and 666561e.

• config/webpack.production.js (1 hunks)
• src/js/core/env.js (1 hunks)
• src/js/module/Editor.js (1 hunks)

src/js/core/env.js (1)

30-41: Approve changes with minor suggestions for improvement

The modifications successfully address the IE9 compatibility issue by checking for the existence of CanvasPixelArray.prototype.join. This change maintains functionality across different browsers while solving the specific problem mentioned in the PR objectives.

However, I have a few suggestions to improve code quality and readability:

1. Consider using a more descriptive name for the variable s, such as pixelDataString.
2. Adjust the indentation of the new code to match the rest of the function.
3. Move the comment "Get pixel information" to before line 30 to accurately reflect its purpose.

Here's a suggested refactor incorporating these changes:

 function getPxInfo(font) {
-    let s = '';
+    // Get pixel information
+    let pixelDataString = '';
     context.clearRect(0, 0, canvasWidth, canvasHeight);
     context.font = fontSize + ' ' + validFontName(font) + ', "' + testFontName + '"';
     context.fillText(testText, canvasWidth / 2, canvasHeight / 2);
-    // Get pixel information
     var pxInfo = context.getImageData(0, 0, canvasWidth, canvasHeight).data;
-    if (CanvasPixelArray.prototype.join) {
-      s = pxInfo.join();
-    } else {
-      for (let i = 0; i < pxInfo.length; i++) s += pxInfo[i].toString();
-    }
-    return s;
+    if (CanvasPixelArray.prototype.join) {
+        pixelDataString = pxInfo.join();
+    } else {
+        for (let i = 0; i < pxInfo.length; i++) pixelDataString += pxInfo[i].toString();
+    }
+    return pixelDataString;
 }

To ensure this change doesn't negatively impact other browsers, please run the following verification script:

config/webpack.production.js (2)

Line range hint 1-214: LGTM - Webpack configuration remains solid with potential for IE9 support

The changes to this file are minimal and don't introduce any immediate issues. The commented-out environment configuration provides a clear path for enabling IE9 support if needed in the future.

The overall webpack configuration remains well-structured for a production build, including:

• Appropriate entry points for styles and languages
• Correct externals configuration for jQuery
• Comprehensive module rules for processing JavaScript and CSS
• Proper optimization settings for minimizing JavaScript and CSS
• Essential plugins for cleaning, copying, and zipping the build output

These configurations align well with the project's needs and the PR's objectives.

---

64-67: Consider enabling ES5 compatibility settings for IE9 support

The commented-out environment configuration in the output section is relevant to the PR's objective of fixing issues in IE9 compatible browsers. However, it's currently inactive.

1. If IE9 support is a priority, consider uncommenting and enabling these settings.
2. If you choose to keep it commented out, please add a comment explaining why it's not enabled and under what circumstances it should be used.

Example documentation:

// Uncomment the following section to enable ES5 compatibility for IE9 support
// environment: {
//   const: false,
//   arrowFunction: false,
// },

This will help future maintainers understand the purpose and potential use of this configuration.

To ensure this change doesn't conflict with other parts of the codebase, please run the following command:

src/js/module/Editor.js (1)

680-684: Summary: Improved IE9 compatibility with minimal risk.

This change introduces better error handling for the 'styleWithCSS' command, which is likely to improve IE9 compatibility as intended. The try-catch block is a safe addition that shouldn't negatively impact other browsers.

Key points:

1. The change addresses the PR objective of fixing issues in IE9 compatible browsers.
2. It introduces minimal risk to existing functionality.
3. Proper testing in IE9 and other browsers is crucial to ensure the change's effectiveness.

Good job on improving the editor's browser compatibility!