Skip to content

Fix a few bugs with top level schema definitions#74

Closed
acao wants to merge 1 commit into
mainfrom
completion-complex-type-bugs
Closed

Fix a few bugs with top level schema definitions#74
acao wants to merge 1 commit into
mainfrom
completion-complex-type-bugs

Conversation

@acao

@acao acao commented Nov 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@changeset-bot

changeset-bot Bot commented Nov 13, 2023 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22c47a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Nov 13, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit 22c47a6
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/656d1da996a4240008a7126e
😎 Deploy Preview https://deploy-preview-74--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acao acao force-pushed the completion-complex-type-bugs branch from 143547b to 22c47a6 Compare December 4, 2023 00:30
imolorhe
imolorhe reviewed May 29, 2024
View reviewed changes
Comment thread src/__tests__/json-completion.spec.ts
]);
});
it("should autocomplete for array of objects with filter", async () => {
await expectCompletion('{ "arrayOfObjects": [ { "f|" } ] }', [

@imolorhe imolorhe May 29, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me locally

imolorhe
imolorhe reviewed May 29, 2024
View reviewed changes
Comment thread src/__tests__/json-completion.spec.ts
]);
});
it("should autocomplete for a schema with top level $ref", async () => {
await expectCompletion(

@imolorhe imolorhe May 29, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on this one ⏱️

imolorhe
imolorhe reviewed May 29, 2024
View reviewed changes
Comment thread src/__tests__/json-completion.spec.ts
{ schema: testSchema3 }
);
});
it("should autocomplete for a schema with top level complex type", async () => {

@imolorhe imolorhe May 29, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on this one ⏱️

@acao

acao commented May 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@imolorhe from what i can tell it is because our getPointer method skips the object root itself

@imolorhe

imolorhe commented May 29, 2024

Copy link
Copy Markdown
Collaborator

@acao I was able to get it working without touching getPointer. Just touching the completion logic, and all tests are passing!

@imolorhe

imolorhe commented May 29, 2024

Copy link
Copy Markdown
Collaborator

Since I'm on it, want to tackle a few other test cases before creating a PR

@acao acao closed this Jun 1, 2024
@acao

acao commented Jun 1, 2024

Copy link
Copy Markdown
Collaborator Author

@imolorhe awesome work! yeah I saw that you added these test cases and todos for the ones left. was awesome to see so many more standard schemas working! closing this for now as the next steps are already in the TODO comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imolorhe imolorhe imolorhe left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acao @imolorhe