build: use rbe platform with network from shared dev-infra build tooling

devversion · alan-agius4 · commit 96d39f8f3a6f · 2022-07-27T12:35:15.000+02:00
This avoids having to manually declare the `platform`. We specifically
added support for the network platform due to the CLI needs.

The CLI repository should long-term set
`--sandbox_default_allow_network=false` in the `bazelrc` so that
internet access is only granted targets explicitly. We should discourage
reliance on internet as much as possible to help with hermetic tests.
diff --git a/.bazelrc b/.bazelrc
@@ -120,9 +120,9 @@ build:remote --jobs=150
 # is provided by the shared dev-infra package and targets k8 remote containers.
 build:remote --crosstool_top=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain_suite
 build:remote --extra_toolchains=@npm//@angular/build-tooling/bazel/remote-execution/cpp:cc_toolchain
-build:remote --extra_execution_platforms=//tools:rbe_platform_with_network_access
-build:remote --host_platform=//tools:rbe_platform_with_network_access
-build:remote --platforms=//tools:rbe_platform_with_network_access
+build:remote --extra_execution_platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
+build:remote --host_platform=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
+build:remote --platforms=@npm//@angular/build-tooling/bazel/remote-execution:platform_with_network
 
 # Set remote caching settings
 build:remote --remote_accept_cached=true
diff --git a/tools/BUILD.bazel b/tools/BUILD.bazel
@@ -28,13 +28,4 @@ nodejs_binary(
     entry_point = "quicktype_runner.js",
     templated_args = ["--bazel_patch_module_resolver"],
 )
-
-platform(
-    name = "rbe_platform_with_network_access",
-    exec_properties = {
-        "dockerNetwork": "standard",
-    },
-    parents = ["@npm//@angular/build-tooling/bazel/remote-execution:platform"],
-)
-
 # @external_end
