Clean sparse checkout directory paths#2180
Open
ibobgunardi wants to merge 1 commit into
Open
Conversation
Signed-off-by: Bobby <[email protected]>
ibobgunardi
force-pushed
the
bobi/sparse-checkout-clean-paths
branch
from
313d7d4 to
492cf20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1506.
Sparse checkout directories are repository-relative paths.
./goshould resolve the same way asgo, but the reset path used the raw strings for tree validation and index skip-worktree matching.This cleans the sparse directory list once in
Resetand reuses it for validation, keep-reset conflict checks, and index updates.Tested with:
go test . -run "TestWorktreeSuite/TestCheckoutSparseRelativeDirs" -count=1 -vgo test . -run "TestWorktreeSuite/Test(CheckoutSparse|CheckoutSparseRelativeDirs|CheckoutForceSparseUntrackedPreserved|ResetSparsely|ResetSparselyInvalidDir|StatusAfterSparseCheckout)$" -count=1 -vgo test . -run "TestWorktreeSuite/TestCheckout" -count=1