feat: Use module name to prevent keyword collision with enum values#1072
Merged
Conversation
dazuma
approved these changes
Apr 25, 2024
aandreassa
added a commit
that referenced
this pull request
May 27, 2026
I previously addressed these keyword collisions in PR #1061 and #1072. However, the previous syntax still generates YARD proxy warnings that cause strict builds to fail (i.e. `fail-on-warning`), an issue observed during CI for `google-apps-card-v1`. This update utilizes `const_set` to successfully bypass the warnings. I verified directly on the gem via manual edits and running `toys yard`.
aandreassa
added a commit
that referenced
this pull request
Jun 4, 2026
I previously addressed these keyword collisions in PR #1061 and #1072. However, the previous syntax still generates YARD proxy warnings that cause strict builds to fail (i.e. `fail-on-warning`), an issue observed during CI for `google-apps-card-v1`. This update utilizes `const_set` to successfully bypass the warnings. I verified directly on the gem via manual edits and running `toys yard`.
aandreassa
added a commit
that referenced
this pull request
Jun 4, 2026
I previously addressed these keyword collisions in PR #1061 and #1072. However, the previous syntax still generates YARD proxy warnings that cause strict builds to fail (i.e. `fail-on-warning`), an issue observed during CI for `google-apps-card-v1`. This update utilizes `const_set` to successfully bypass the warnings. I verified directly on the gem via manual edits and running `toys yard`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slight change from #1061 in order to be compatible with yard. It now uses the module name instead of
self.