Conversation
|
@seanpoulter can you check why the tests are failing? |
|
Could you please try again @isomorphic-git-bot? |
|
The bot doesn't work anymore, I think it was using prettier to fix the code, but it don't do this anymore. |
|
If you updated your branch (from a fork) I will need to merge the changes. |
Ah, we probably need to grant it permissions to modify the content. |
I don't even know where to look at for that bot. |
df60de6 to
460175b
Compare
|
Can we do anything with this issue? It looks like there's a timeout error for running GitHub action. If this is the issue, then maybe we can remove some old browsers. Or add parallelization if it's not already added. There are also those errors: |
|
@jcubic, could you please rerun the workflows so we can see the logs? |
|
I don't know how, I can only restart isomorphic-git-PR, but that one is Azure. I can invite you to be part of the org. |
|
Let me know if you want to be part of the org, I don't remember if you said that you don't want to. There are few people in the org already and they are not active. There are no obligations after you join. |
|
Here's the documentation to retry a workflow. I'm happy to jump on a call if you want to walk through it or discuss this synchronously. I'm happy to join the organization if it'll help grant me permissions to contribute to this branch and run the GitHub Workflows so we can test this and get it resolved sooner. 👍 I was going to suggest working in very small steps to get this moving. First, we've got to get this running with at least one version of Node. |
|
Invited you as a member. Let me know if you have all access you need. |
|
It seems it work what was the issue? Let me know when this is ready and can be merged. |
|
One of three of checks timed out after 30 minutes the first time. I retried it and it passed. I don't know why it was failing before. I can't see the logs. Before we merge, I'd suggest we:
After we merge, I'd suggest we:
graph LR
Start@{ shape: circle, label: " " } --> B
subgraph Build
B(lint<br>test.typecheck) --> D(build) --> Jest(test.setup<br>test.jest) --> E(Cache)
end
subgraph "Test (Browser)"
E --> G(test.setup<br>test.karma - Browser 1)
E --> H(test.setup<br>test.karma for Browser ...)
E --> I(test.setup<br>test.karma for Browser n)
end
G --> End@{ shape: dbl-circ, label: " " }
H --> End
I --> End
|
|
Sounds like a plan, go for it. Let me know when you will want something from me. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI/CD configuration to use GitHub Workflow while streamlining several package scripts and removing an obsolete helper file. Key changes include:
- Enhancements in package-scripts.cjs to add NODE_OPTIONS for Node.js v17+ and updates to webpack, jest, and karma commands.
- Disabling steps in azure-pipelines.yml by commenting them out.
- Removal of the tweet.cjs helper file.
- Introduction of a new GitHub workflow configuration in .github/workflows/ci_cd.yml.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package-scripts.cjs | Updated Node.js options handling and command modifications for CI/CD. |
| azure-pipelines.yml | Commented out legacy CI steps for npm publishing and website updates. |
| tests/helpers/tweet.cjs | Removed an outdated helper used for tweeting. |
| .github/workflows/ci_cd.yml | Added a new GitHub workflow configuration for CI/CD pipelines. |
Files not reviewed (3)
- .nvmrc: Language not supported
- .releaserc: Language not supported
- package.json: Language not supported
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI/CD pipeline by introducing a new GitHub Actions workflow and adjusts the project’s build scripts to support Node.js v17 changes.
- Added Node.js v17 OpenSSL legacy provider configuration and updated build commands in package-scripts.cjs
- Removed the tweet helper script, which is no longer used
- Introduced a new GitHub Actions workflow to drive CI/CD
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package-scripts.cjs | Added OpenSSL legacy provider support and updated commands for webpack, jest, and karma |
| tests/helpers/tweet.cjs | Removed no-longer-needed tweet helper script |
| .github/workflows/ci_cd.yml | Added a new GitHub Actions workflow for CI/CD |
Files not reviewed (3)
- .nvmrc: Language not supported
- .releaserc: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
package-scripts.cjs:146
- The removal of the retry3 logic for the jest command changes the test behavior in CI. Please confirm that this change is intentional and that the lack of retry behavior in CI is acceptable.
jest: `jest --ci --coverage`,
.github/workflows/ci_cd.yml:33
- Using fromJSON with a formatted string for node-version inputs relies on the input being correctly formatted. Validate that the comma-separated input converts to a proper JSON array to avoid runtime errors in the workflow.
node-version: ${{ fromJSON(format('[{0}]', inputs.node-version || '14, 16')) }}
Another attempt to merge GitHub workflow to main.