HTTP/2 cleartext support#8127
Open
hytromo wants to merge 6 commits into
Open
Conversation
Contributor
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
autofix.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for h2c (cleartext HTTP/2) connections via prior knowledge, where the client sends the HTTP/2 connection preface directly.
Motivation
Cleartext http/2 has been discussed before #3362, #2116, #6998 and there has been an attempt to make this work in the past #4661 - so there is community interest in this feature.
In my case, I am making gRPC calls with Istio handling TLS, resulting in HTTP/2 cleartext calls from the application's viewpoint. Adding
mitmproxyto this mix seems impossible without h2c support.Validation
Apart from the existing working and new tests, I also tested recording and replaying h2c requests with success.
Checklist