Ensure 'undefined' does not make it into tsserver.web.js#164064
Merged
Conversation
mjbvz
approved these changes
Oct 19, 2022
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS 5.0 won't include
dynamicImportCompat; I noticed while vetting VS Code's usage of it that if the file doesn't exist, it accidentally putsundefinedinto the output file.This technically works because of automatic semicolon insertion (there's a newline after
undefined), but there's no reason to include that expression in the file if we don't have to, and now we can avoid doing string manipulation for TS 5.0+ which will make the build slightly faster.