Conformer separation#1519
Merged
Merged
Conversation
…s_embs argument in ConformerEncoder
popcornell
approved these changes
Jul 28, 2022
anautsch
approved these changes
Oct 5, 2022
anautsch
left a comment
anautsch
left a comment
Collaborator
There was a problem hiding this comment.
lgtm - there's a small thing to change in the yaml file.
I couldn't run a test since I've no access to LDC data.
Is there a comparable mini dataset that I could use to run the recipe in --debug mode ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a wrapper class to use conformer for separation.
Also a small fix to remove the 'optional' from
pos_embsargument ofConformerEncoderforward function, as it requires specifying the positional embeddings (it is not optional).