Fix disable privileged ports for OSX#163890
Merged
Merged
Conversation
mcbridenMoey
previously approved these changes
Oct 17, 2022
alexr00
requested changes
Oct 17, 2022
alexr00
left a comment
alexr00
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Just a few comments.
alexr00
reviewed
Oct 18, 2022
alexr00
left a comment
alexr00
left a comment
Member
There was a problem hiding this comment.
I'm going to do some testing then I'll approve. Thanks for the changes!
jeanp413
force-pushed
the
mac-priviledge-ports
branch
from
e9721d7 to
8480146
Compare
rebornix
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160266
Requires to update setting
"remote.localPortHost": "allInterfaces"in macos to properly work