Improved rake install#5928
Merged
Merged
Conversation
This is so that the build directory can be regarded as a temporary installation directory to work in. Directories set in `MRuby::Gem::Specification#export_include_paths` are used as they are if they are subdirectories placed under `gem.dir`. Files are placed under `<build-dir>/include/mruby/gems/<gem-name>/<gem-include_paths>` to separate each GEM. When GEM is compiled by building `libmruby.a`, the same `include_paths` will be set as before, so it is expected that no unintended references will be made.
Build targets other than "host" will be installed under `<PREFIX>/mruby/<build-name>`. This can be changed with `build.install_prefix = dir`.
If the environment variable `DESTDIR` is set, the writing destination is `<DESTDIR>/<PREFIX>/...`. It is assumed to be used for package work.
Since `bin/mruby-config` now points to a directory relative to itself, it is no longer possible to reach `include/` or `lib/`. Therefore, avoid placing entities in them.
68f281f to
7c7ed3c
Compare
Contributor
Author
|
Fixed https://github.com/mruby/mruby/actions/runs/4156525680/jobs/7190371416 The variable |
dearblue
added a commit
to dearblue/mruby
that referenced
this pull request
May 6, 2023
This is a complement to mruby#5928. The previous PR had the following problem: - The `<INSTALL_DIR>/bin/*` file could not be replaced if the destination of the symbolic link was lost. - The wrong link destination was written if `MRuby::Build.install_dir` was a relative path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
tasks/install.rakefile will be added.bin/mruby-configandlib/libmruby.makfiles do not reference the original header files.rake install:fullwill also install build targets other than "host".MRuby::Build#install_prefix = dirwill change the installation directory.The default is
<PREFIX>/directory for "host" and<PREFIX>/mruby/<build-name>/directory for anything other than "host".DESTDIRis set, it is referenced as the prefix of the actual write destination.doc/guides/compile.mdhas been translated from Japanese to English by DeepL.