Makes untrusted domain error on info#33737
Merged
Merged
Conversation
Signed-off-by: Andy Xheli <[email protected]> Since e6d9ef2 was applied logs get filled up with Trusted domain error. "X.X.X.X tried to access using "X.X.X.X" as host alot of users missed important errors do tohttps://github.com/nextcloud/server/commit/e6d9ef2e38daffcab808eaa41b18ab16c6253b97 please see #32599 This should fix. #32599 (comment) Signed-off-by: Andy Xheli <[email protected]>
Merged
|
How ist this working? |
Merged
Contributor
Author
|
Hi All. Can we please get a review on this? |
szaimen
requested review from
a team,
come-nc and
juliusknorr
and removed request for
a team
come-nc
approved these changes
Oct 1, 2022
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Not clear if there is not a better solution here, but for the time being…
Contributor
Author
|
Thank you!! I'm sure there will be some happy admins :) |
Contributor
Author
|
Hey @szaimen I just updated to NC 24.0.6 and im not seeing this change in there. and i updated my NC 25 to RC3 and i dont see the change there also Can you please look into this ? |
8 tasks
Contributor
|
/backport to stable25 |
Contributor
|
/backport to stable24 |
This was referenced Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Xheli [email protected]
Since e6d9ef2 was applied logs get filled up with Trusted domain error. "X.X.X.X tried to access using "X.X.X.X" as host alot of users missed important errors do to e6d9ef2 please see #32599
This should fix.
#32599 (comment)