Skip to content

doc: add missing backticks to doc/api/tls.md#13394

Closed
pbininda wants to merge 1 commit into
nodejs:masterfrom
pbininda:issue13382
Closed

doc: add missing backticks to doc/api/tls.md#13394
pbininda wants to merge 1 commit into
nodejs:masterfrom
pbininda:issue13382

Conversation

@pbininda

@pbininda pbininda commented Jun 2, 2017

Copy link
Copy Markdown
Contributor

Fixes: #13382

Checklist
Affected core subsystem(s)

doc, tls

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jun 2, 2017
@refack

refack commented Jun 2, 2017

Copy link
Copy Markdown
Contributor

@pbininda Thank you very much for the contribution 🥇

I'd recommend you make yourself familiar with our review & landing procedure

Good luck 🤞

@refack refack self-assigned this Jun 2, 2017
@refack

refack commented Jun 2, 2017

Copy link
Copy Markdown
Contributor

Ohh and welcome 😉
image

@gibfahn

gibfahn commented Jun 2, 2017

Copy link
Copy Markdown
Member

Yep, the issue is clear in the docs. Thanks for this @pbininda !

image

Copying the dont-land-on labels from #11984

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

refack pushed a commit to refack/node that referenced this pull request Jun 4, 2017
PR-URL: nodejs#13394
Fixes: nodejs#13382
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack

refack commented Jun 4, 2017

Copy link
Copy Markdown
Contributor

Landed in 7637347

@refack refack closed this Jun 4, 2017
jasnell pushed a commit that referenced this pull request Jun 5, 2017
PR-URL: #13394
Fixes: #13382
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request Jun 5, 2017
@refack refack removed their assignment Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: incorrect backtick usage

8 participants