http: validate timeout in ClientRequest()#26214
Merged
Merged
Conversation
BridgeAR
reviewed
Feb 20, 2019
BridgeAR
left a comment
BridgeAR
left a comment
Member
There was a problem hiding this comment.
Definitely +1 on the behavior change but the error message seems like it could use a better description as there's no 'msecs' argument in the request. Adding a optional second argument to the validateTimerDuration to replace msecs with timeout would already be better (even though it's still not an argument).
2 tasks
lpinca
added
the
semver-major
jasnell
approved these changes
Feb 21, 2019
Contributor
Author
geek
approved these changes
Feb 26, 2019
Contributor
Author
|
@nodejs/tsc this needs at least two reviews since it's semver major (James' review doesn't currently count toward that). |
ofrobots
approved these changes
Feb 26, 2019
targos
approved these changes
Feb 26, 2019
Validate the timeout option in the ClientRequest() constructor to prevent asynchronously thrown validation errors. PR-URL: nodejs#26214 Fixes: nodejs#26143 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Contributor
Author
|
Thanks for the reviews! Landed in 907941d. |
Merged
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the
timeoutoption in theClientRequest()constructor to prevent asynchronously thrown validation errors.Fixes: #26143
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes