buffer: use for...of#30962
Closed
trivikr wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
the
buffer
Contributor
|
Can you consolidate these PRs? All of the separate PRs makes for a lot of noise. |
Member
Author
I've posted PRs specific to submodules - buffer, stream, http, tls A single PR might get blocked/delayed/might not land in old versions/etc because of changes specific to any of the submodules. |
Contributor
|
You could use separate commits in a single PR. |
Collaborator
Contributor
|
Would be curious to know how much affects concat performance. |
mcollina
requested changes
Dec 14, 2019
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
I think we should keep this as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched for regular expression
for \([^\.]*.lengthinliband made changes inbuffer.jsRefs: #30910 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes