Skip to content

lib: refactor to use primordials in lib/internal/cli_table#38046

Merged
Trott merged 1 commit into
nodejs:masterfrom
marsonya:primordials-lib-internal-cli_table
Apr 6, 2021
Merged

lib: refactor to use primordials in lib/internal/cli_table#38046
Trott merged 1 commit into
nodejs:masterfrom
marsonya:primordials-lib-internal-cli_table

Conversation

@marsonya

@marsonya marsonya commented Apr 2, 2021

Copy link
Copy Markdown
Member

Replace code that's vulnerable to Prototype Pollution with Primordials.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 2, 2021
Comment thread lib/internal/cli_table.js Outdated
Comment thread lib/internal/cli_table.js Outdated
Comment thread lib/internal/cli_table.js Outdated
Comment thread lib/internal/cli_table.js Outdated
@RaisinTen

Copy link
Copy Markdown
Member

Shouldn't the subsystem in the commit message be lib instead of src?

@marsonya marsonya changed the title src: refactor to use primordials in lib/internal/cli_table lib: refactor to use primordials in lib/internal/cli_table Apr 3, 2021
@marsonya

marsonya commented Apr 3, 2021

Copy link
Copy Markdown
Member Author

Shouldn't the subsystem in the commit message be lib instead of src?

Thanks for catching that. Fixed it.

Comment thread lib/internal/cli_table.js Outdated
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

PR-URL: #38046
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott merged commit a9332e8 into nodejs:master Apr 6, 2021
@Trott

Trott commented Apr 6, 2021

Copy link
Copy Markdown
Member

Landed in a9332e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants