doc: improved readability#43694
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dns
Member
|
We lint for "hostname" as a prohibited string in favour of "host name": https://github.com/nodejs/remark-preset-lint-node/blob/c0d7ffbaeaa686208dd4a7865bcc1ea07dc33fca/index.js#L93 |
Contributor
Author
|
@richardlau understood, I'll correct it |
benjamingr
approved these changes
Jul 5, 2022
benjamingr
added
the
fast-track
Contributor
|
Fast-track has been requested by @benjamingr. Please 👍 to approve. |
VoltrexKeyva
approved these changes
Jul 6, 2022
HarshithaKP
approved these changes
Jul 6, 2022
Member
|
Any chance you can change the commit message to adhere to the guidelines changing |
Contributor
Author
|
@benjamingr to be clear, I'll have to change the title to 'docs: improved readability' and the commit message to same as well? |
Contributor
Author
|
I'm closing this PR for now, will come with a fix |
Contributor
|
Landed in 9512da0 |
Contributor
Author
|
Great! Thank you |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43694 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43694 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43694 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43694 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Harshitha K P <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed some grammar