feat: add Google Contacts (People API) provider#355
Open
cfis wants to merge 1 commit into
Open
Conversation
Mirrors the existing Google Workspace app pattern. Routes people.googleapis.com through Bearer + GOOGLE_REFRESH, sharing OAuth config fields with other Google providers. Scopes: contacts.readonly, contacts.other.readonly (default); contacts and directory.readonly available as toggleable permissions. Tests: 4 new assertions in apps.rs covering host routing, bearer injection, and provider-for-host lookup. cargo test apps:: → 117 passed, 0 failed. Note: included icon is a placeholder using Material Design's contacts glyph in Google blue (#1A73E8); maintainers may want to swap for an official Google Contacts brand asset. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
cfis
force-pushed
the
feat/google-contacts-provider
branch
from
cc15790 to
aa582d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Google Contacts as a new OAuth app provider, routing
people.googleapis.comthrough OneCLI's standard Google OAuth + refresh flow. Mirrors the existing Google Workspace app pattern (single-host subdomain → Bearer auth → sharedGOOGLE_REFRESHconfig).Default scopes:
contacts.readonly+contacts.other.readonly. Full write (contacts) and directory (directory.readonly) available as toggleable permissions in the UI.Files
packages/api/src/apps/google-contacts.ts— app definition (mirrorsgoogle-docs.ts)packages/api/src/apps/app-permissions/google-contacts.ts— tool/scope definitions for the permissions UIpackages/api/src/apps/registry.ts— register in static apps listpackages/api/src/apps/app-permissions/index.ts— register permissionsapps/gateway/src/apps.rs— newAppProviderentry routingpeople.googleapis.comwith Bearer + GOOGLE_REFRESH, plus 4 test entriesapps/web/public/icons/google-contacts.svg— placeholder icon (Material Design contacts glyph in Google blue#1A73E8); maintainers may want to swap for an official assetTest plan
cargo fmt --checkpassescargo clippy -- -D warningspassescargo test apps::— 117 passed, 0 failed (4 new assertions added to existing test functions + 2 new dedicated tests:google_contacts_api_uses_bearer,provider_for_host_google_contacts)pnpm check-types,pnpm lint,pnpm format:checkall pass (run via husky pre-push)https://people.googleapis.com/v1/people/me/connectionsreturns 200 with injected bearer