streams: implement min option for ReadableStreamBYOBReader.read(view)#50888
Merged
Conversation
Collaborator
|
Review requested:
|
MattiasBuelens
changed the title
min option for ReadableStreamBYOBReader.read(view)
MattiasBuelens
commented
Nov 23, 2023
MattiasBuelens
commented
Nov 23, 2023
Contributor
|
I guess this will need a rebase now that .cancel implementation has landed |
ljharb
reviewed
Dec 31, 2023
benjamingr
approved these changes
Jan 1, 2024
github-actions
Bot
removed
the
request-ci
Collaborator
Member
|
There seems to be a lot of CI failures |
Contributor
Author
Yes, I think I accidentally broke some more tests with the stricter validation rules. 😅 Working on it! |
github-actions
Bot
removed
the
request-ci
Merged
Member
|
This doesn't land cleanly on v20.x-staging and will need a manual backport. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
ReadableStreamBYOBReader.read(view, { min }). When theminoption is given, the read will only be fulfilled as soon asminnumber of elements are available in the readable byte stream.Specification: https://streams.spec.whatwg.org/#byob-reader-read
Tests: web-platform-tests/wpt#29723
This is ported pretty much directly from the reference implementation, see whatwg/streams#1145.
Fixes #50706
Todo