Make PublicKeyCredentialCreationOptions Serializable#18354
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
|
any updates on this ^^? |
rwinch
added
type: enhancement
Member
|
Thanks for the PR @pahlevani I've fixed the checkstyle errors and rebased the PR on the current main. As soon as the build passes, this will be merged into main 701736d |
Closes gh-16431 Signed-off-by: Mohammad Amin Pahlevani <[email protected]>
Issue gh-18354 Signed-off-by: Robert Winch <[email protected]>
|
@pahlevani Great work! This must be backported to the 7.0.x release. @rwinch we are blocked because we implemented our own From our perspective this is a bug, because even in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-16431
It doesn’t appear to be fixed yet—there hasn’t been an accepted or merged change addressing it in any released version. It’s possible there was a misunderstanding involving the class names PublicKeyCredentialRequestOptions and PublicKeyCredentialCreationOptions, or a mix-up with issues gh-16431 and gh-16432.
Related issues:
PublicKeyCredentialCreationOptionsSerializable#16431.