Various examples shape-ups#5272
Merged
Merged
Conversation
pks-t
requested changes
Oct 17, 2019
pks-t
left a comment
pks-t
left a comment
Member
There was a problem hiding this comment.
There's some very nice improvements here, thanks a lot! I'm mostly very happy about your changes, the only thing I don't like is the rename of lg2_add to lg2_index_add. Everything else is just stylistic or minor stuff
tiennou
force-pushed
the
examples/cli-ification
branch
from
2469579 to
357c283
Compare
Contributor
Author
|
Rebased, I took some time to tackle all review comments, as well as a few more drastic changes — the "assert.h" cleanup is now global, since it's in both libgit2's and lg2's "common.h". |
pks-t
reviewed
Nov 5, 2019
pks-t
left a comment
pks-t
left a comment
Member
There was a problem hiding this comment.
Some really minor comments which should be quick to fix up, otherwise this looks very good to me!
tiennou
force-pushed
the
examples/cli-ification
branch
from
357c283 to
25fa379
Compare
tiennou
force-pushed
the
examples/cli-ification
branch
2 times, most recently
from
4e12cba to
0b64465
Compare
This allows the example to be used as a quick revwalk test harness.
tiennou
force-pushed
the
examples/cli-ification
branch
from
0b64465 to
fe42557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some commits to the example code that shape it up a little bit, the kind of things that tends to be lost on various branches when debugging. Note that this hasn't been really tested — I don't expect any obviously broken things, but as I don't remember the actual goal of 3f68eff, for example, I'm not confident 😜.
As a side note, I've rebased the example/pull WIP on top of that, as I've managed to pinpoint another lost-but-interesting commit with the tracking-remote creation helper started but incomplete.