write-entities: nicer progress status#51
Merged
Merged
Conversation
This makes two changes to make a progress status a bit nicer: - Print the number with thousands separator, e.g. "150_000" instead of 150000". - For interactive terminals it will also replace the current line rather than printing a new one. "\r" moves the cursor to the first column, and "\x1b[K" clears the line. This works on all current terminals ( where "current" means "since the 90s").
stchris
approved these changes
Aug 1, 2024
stchris
left a comment
stchris
left a comment
Contributor
There was a problem hiding this comment.
I like this quite a bit, thanks for the change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes to make a progress status a bit nicer:
Print the number with thousands separator, e.g. "150_000" instead of 150000".
For interactive terminals it will also replace the current line rather than printing a new one. "\r" moves the cursor to the first column, and "\x1b[K" clears the line. This works on all current terminals ( where "current" means "since the 90s").