chore: update protobuf workspace dependency to v3.13.0.#233
chore: update protobuf workspace dependency to v3.13.0.#233yoshi-automation wants to merge 1 commit into
Conversation
PiperOrigin-RevId: 327026955 Source-Author: Google APIs <[email protected]> Source-Date: Mon Aug 17 08:40:22 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 0dc0a6c0f1a9f979bc0690f0caa5fbafa3000c2c Source-Link: googleapis/googleapis@0dc0a6c
google-cla
Bot
added
the
cla: yes
| # Generated by the protocol buffer compiler. DO NOT EDIT! | ||
| # source: google/cloud/bigquery_v2/proto/encryption_config.proto | ||
|
|
||
| """Generated protocol buffer code.""" |
There was a problem hiding this comment.
Grrrr, we've got dueling synths going here, adding and removing just this one line. @software-dov, @busunkim96, any clues why?
There was a problem hiding this comment.
Hmm, it looks like line was removed in a manual regen. Perhaps an older version of a dependency was used there?
There was a problem hiding this comment.
Bigtable has similar back-and-forth, with bot-generated changes only, in https://github.com/googleapis/python-bigtable/pull/111/files
There was a problem hiding this comment.
The mega-generator still uses protoc, right? I'm assuming that migrating to proto-plus would be a V2 sort of thing.
There was a problem hiding this comment.
@tseaver Yep! It still uses protoc. proto-plus will come along with the microgen.
Maybe protobuf itself is flip-flopping on the presence of this comment between versions? This PR was supposedly triggered by a new protobuf
version googleapis/googleapis@0dc0a6c
tseaver
changed the title
| "git": { | ||
| "name": "synthtool", | ||
| "remote": "https://github.com/googleapis/synthtool.git", | ||
| "sha": "c3caf0704f25a0c365f1c315e804a30b87c62a75" |
There was a problem hiding this comment.
Another oddity: why is this stanza repeated? @software-dov, @busunkim96 PTAL
There was a problem hiding this comment.
@SurferJeffAtGoogle Is a duplication of synthtool expected?
There was a problem hiding this comment.
@SurferJeffAtGoogle I can confirm that the duplication occurs here in a manual synth, and in other repositories (python-bigtable, at least, has had it doubled since 2020-06-15).
product-auto-label
Bot
added
the
api: bigquery
|
Superseded by #256. |
3 participants
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/99f82d00-056c-44fe-a21f-a221cdf62a06/targets
PiperOrigin-RevId: 327026955
Source-Link: googleapis/googleapis@0dc0a6c