Fixing shuffle argument for distributed sampler in core.py#1518
Merged
mravanelli merged 1 commit intoJul 26, 2022
Conversation
Collaborator
|
If the tests pass, we can merge @RuABraun |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently shuffling of the sample indices is not done before distributing the indices across nodes, this means the distribution will be the same for each epoch. This causes a small but noticeable decrease in performance.
Fixes #1495
I don't think there's ever a reason to have it set to False, therefore hardcoded to True.
I also took the liberty of adding a tiny bit of extra info to why
DistributedSamplerWrapperneeds to exist.