Skip to content

Fastspeech2#1572

Merged
mravanelli merged 97 commits into
speechbrain:developfrom
bloodraven66:fastspeech2
Jul 17, 2023
Merged

Fastspeech2#1572
mravanelli merged 97 commits into
speechbrain:developfrom
bloodraven66:fastspeech2

Conversation

@bloodraven66

Copy link
Copy Markdown
Contributor

@mravanelli , same as fastpitch, need to refactor a bit once fastspeech is merged.

@BenoitWang

Copy link
Copy Markdown
Collaborator

Hi @bloodraven66, I start with fastspeech2 while I am running fastpitch.
The quality seems very good! Some small points :

  1. better with speechbrain CNN wrappers
  2. please update the docstrings
  3. seems better to use MSELoss for duration, energy and pitch
  4. don't forget to add the recipe into test/recipes.csv

I will do a more detailed review when the tests are finished, thanks!

@mravanelli mravanelli requested a review from BenoitWang November 2, 2022 16:07
Comment thread recipes/LJSpeech/TTS/README.md Outdated
Comment thread recipes/LJSpeech/TTS/fastspeech/hparams/train.yaml Outdated
Comment thread recipes/LJSpeech/TTS/fastspeech2/hparams/train.yaml Outdated
Comment thread recipes/LJSpeech/TTS/fastspeech2/hparams/train.yaml Outdated
Comment thread recipes/LJSpeech/TTS/fastspeech2/hparams/train.yaml Outdated
Comment thread recipes/LJSpeech/TTS/README.md Outdated
Comment thread recipes/LJSpeech/TTS/fastspeech2/hparams/train.yaml Outdated
Comment thread recipes/LJSpeech/TTS/fastspeech2/train.py Outdated
Comment thread recipes/LJSpeech/TTS/fastspeech2/train.py
Comment thread speechbrain/lobes/models/FastSpeech.py Outdated
Comment thread speechbrain/lobes/models/FastSpeech2.py Outdated
Comment thread speechbrain/lobes/models/FastSpeech2.py Outdated
Comment thread speechbrain/lobes/models/FastSpeech2.py Outdated
Comment thread speechbrain/lobes/models/FastSpeech2.py Outdated
@mravanelli mravanelli self-requested a review July 17, 2023 16:03
@mravanelli

Copy link
Copy Markdown
Collaborator

Everything LGTM! It was quite a challenge obtaining satisfactory results with the fastspeech2 model. However, after remarkable efforts, we now have an exceptional fastspeech2 TTS in SpeechBrain. Thank you @BenoitWang @bloodraven66 @pradnya-git-dev and others for your commitment and hard work.

@mravanelli mravanelli merged commit 7510c5b into speechbrain:develop Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants