Skip to content

3.12 CI fix: pin gensim version to newer version#2581

Merged
mravanelli merged 1 commit into
speechbrain:developfrom
asumagic:gensim-ci-fix
Jun 25, 2024
Merged

3.12 CI fix: pin gensim version to newer version#2581
mravanelli merged 1 commit into
speechbrain:developfrom
asumagic:gensim-ci-fix

Conversation

@asumagic

@asumagic asumagic commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes CI by forcing a newer gensim version, which seems compatible with numpy 2.x.

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@asumagic asumagic self-assigned this Jun 25, 2024
@asumagic asumagic changed the title 3.12 CI fix attempt: pin gensim version to newer version 3.12 CI fix: pin gensim version to newer version Jun 25, 2024
@asumagic asumagic marked this pull request as ready for review June 25, 2024 10:41
@asumagic asumagic requested a review from mravanelli June 25, 2024 10:41
@asumagic asumagic mentioned this pull request Jun 25, 2024
Merged
13 tasks
@mravanelli

mravanelli commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

Thank you @asumagic!

@mravanelli mravanelli merged commit 36734b6 into speechbrain:develop Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mravanelli mravanelli mravanelli approved these changes

Assignees

@asumagic asumagic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asumagic @mravanelli