Skip to content

Consistent naming of DB Browser for SQLite#2224

Merged
justinclift merged 2 commits into
sqlitebrowser:masterfrom
horst-p-w-neubauer:Naming-DB-Browser-for-SQLite-base
Apr 30, 2020
Merged

Consistent naming of DB Browser for SQLite#2224
justinclift merged 2 commits into
sqlitebrowser:masterfrom
horst-p-w-neubauer:Naming-DB-Browser-for-SQLite-base

Conversation

@horst-p-w-neubauer

Copy link
Copy Markdown
Member

done:

  • change all DB4S to DB Browser for SQLite
  • change "Click the button to create a DB4S certificate" to "Click the button to 'Generate client certificate'"

done:
* change all DB4S to DB Browser for SQLite
* change "Click the button to create a DB4S certificate" to "Click the button to 'Generate client certificate'"
@horst-p-w-neubauer

Copy link
Copy Markdown
Member Author

Before merging the .ts files should be updated - I'm just waiting for approval of the text changes.

@justinclift

Copy link
Copy Markdown
Member

Yep, the text changes here are good. 😄

@horst-p-w-neubauer

Copy link
Copy Markdown
Member Author

When I update the .ts files I get some more changes than those I've initiated, I'd push them too. The alternative would be to extract them manually - that might be dangerous.

@horst-p-w-neubauer

Copy link
Copy Markdown
Member Author

@justinclift, What about the libs\qscintilla\Qt4Qt5*.ts files? Should I commit the changes or ignore?

@scottfurry

scottfurry commented Apr 30, 2020 via email

Copy link
Copy Markdown
Contributor

translation files updated expect libs
@horst-p-w-neubauer

Copy link
Copy Markdown
Member Author

translating itself is probably a different commit / pr cycle

@justinclift

Copy link
Copy Markdown
Member

Yep, the translating itself is a different PR, as that'll need to be done by a bunch of different people.

Sounds like this PR is ready to merge now though. Yes? 😄

@horst-p-w-neubauer

Copy link
Copy Markdown
Member Author

Yes!

@justinclift

Copy link
Copy Markdown
Member

Awesome! Thanks heaps for taking care of this stuff @horst-p-w-neubauer. 😄

@justinclift justinclift merged commit 253fcae into sqlitebrowser:master Apr 30, 2020
@horst-p-w-neubauer horst-p-w-neubauer deleted the Naming-DB-Browser-for-SQLite-base branch April 30, 2020 22:31
@justinclift

Copy link
Copy Markdown
Member

I've just applied this PR to the v3.12.x branch too, for good measure. 😄

@justinclift justinclift added this to the 3.12.0 - Next release milestone Apr 30, 2020
@justinclift justinclift changed the title consistent naming of DB Browser for SQLite Consistent naming of DB Browser for SQLite Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants