Updates the Portuguese (BR) translations for v3.12.x#2418
Merged
lucydodo merged 2 commits intoOct 2, 2020
Merged
Conversation
lucydodo
requested changes
Oct 2, 2020
lucydodo
left a comment
lucydodo
left a comment
Member
There was a problem hiding this comment.
Thanks for contributing!
There are items that need just one simple modifications. Please check them. 😄
Member
And I think it is a reasonable opinion. |
Contributor
Author
|
@lucydodo I've removed the empty translations. |
lucydodo
approved these changes
Oct 2, 2020
Member
|
LGTM! Thanks for modification. Now it just squash and merge. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is towards #2405.
I took care to properly align these strings, but this should probably be done by software. I think you will agree that it makes no sense to require all translators to manually align these strings rather than just splitting each line into two strings and adding as many spaces are required for proper alignment. That would also be less error-prone.
There are now warnings for the Portuguese translation (regarding the different number of leading spaces) because of this.
Some of the text in the program is manually line-split, I don't know how much sense this makes as different resolutions and font sizes could make something that looks OK to a developer look very strange to an end-user. Maybe there is a way to get line-wrapping done by software here.