Skip to content

TS: cap skip with execution timeout#10560

Open
feiyang3cat wants to merge 1 commit into
temporalio:mainfrom
feiyang3cat:ts-execution-timeout
Open

TS: cap skip with execution timeout#10560
feiyang3cat wants to merge 1 commit into
temporalio:mainfrom
feiyang3cat:ts-execution-timeout

Conversation

@feiyang3cat
Copy link
Copy Markdown
Contributor

@feiyang3cat feiyang3cat commented Jun 5, 2026

What changed?

  1. cap the target time with workflow execution/run timeout (if this timeout is not nil and not zero)
  2. add a test case to use time skipping to test execution/run timeouts

Why?

  1. it doesn't make sense if we skip pass the completion of the workflow when it is per-execution timeout now but normally we don't regard execution/run timeout as a point to skip to
  2. time skipping is also a tool to test execution timeouts

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@feiyang3cat feiyang3cat requested review from a team as code owners June 5, 2026 21:14
@feiyang3cat feiyang3cat force-pushed the ts-execution-timeout branch 3 times, most recently from 1f5d449 to 89706ef Compare June 5, 2026 21:42
@feiyang3cat feiyang3cat changed the title fix bug that bound is larger than timeout of execution TS: cap skip with execution timeout Jun 5, 2026
@feiyang3cat feiyang3cat force-pushed the ts-execution-timeout branch 4 times, most recently from e9ccc81 to ba2cded Compare June 5, 2026 22:14
@feiyang3cat feiyang3cat force-pushed the ts-execution-timeout branch from ba2cded to 7519aad Compare June 5, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants