This repository was archived by the owner on Feb 8, 2020. It is now read-only.
Schema/update#178
Open
jeanbaptistemorin wants to merge 4 commits into
Open
Conversation
|
|
killix
suggested changes
Aug 24, 2017
killix
left a comment
killix
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR. Basically context is a duplicate of Object use in the object Object. This is use to pass additinal data as the context. (usefull in flowdock case to track the thread). Check https://www.w3.org/TR/activitystreams-vocabulary/#dfn-context
| "embedded/tag", | ||
| "object/collection", | ||
| "object/context", | ||
| "object/media", |
Collaborator
There was a problem hiding this comment.
object need also to be in the list ;)
| - $ref: "http://schemas.broid.ai/object/place.json" | ||
| required: [ type, id, latitude, longitude ] | ||
| - $ref: "http://schemas.broid.ai/object/collection.json" | ||
| required: [ type, items ] |
| - embedded/tag | ||
| - object/collection | ||
| - object/context | ||
| - object/media |
Collaborator
There was a problem hiding this comment.
- object/context, need to be here also
Author
|
@killix thanks! Reverted the object/object back with to fit the doc. Is that correct? Note for later: As |
Author
|
Forgot the attachements. ✋ Will add that 🕐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 🤖, small PR on schemas!
js-beautifyto have readable outputobject.jsonlooks more like acontext.jsonaccording to the docs. "Object" in the documentation is more the base object of all the Objects, or a generic type for Context and Tags, right? Moved theobject.jsonincontext.jsonCollections: moved to onlyMediaitems in activity for now, discussed with @killixObjectenum in tag.idin context.What do you think?