ci: add JDK 26 testing support#13352
Draft
lqiu96 wants to merge 16 commits into
Draft
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
lqiu96
force-pushed
the
add-jdk-26-support
branch
from
4e26dcc to
b611b53
Compare
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Error Prone configuration across the parent and child POMs to support JDK 21+ while maintaining compatibility with older JDKs via profiles. It also addresses various Error Prone warnings by replacing null assertions, removing unused imports, and refactoring code. Feedback on the changes suggests preserving the blocking f.get() calls in EnhancedBigtableStubTest by using assertThat(f.get()).isNull() instead of deleting the assertions entirely, which could lead to race conditions. Additionally, it is recommended to rename the misleadingly named limit iterator variable in DatastoreHelper to results or iterator for better readability.
Add JDK 26 to build matrices in GitHub Actions workflows. Update Bazel integration tests in sdk-platform-java to run on JDK 25 and 26 with Security Manager override. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Bump Error Prone version to 2.45.0 to support compilation on JDK 26. This resolves compilation failures due to internal javac API changes in JDK 26. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Define error-prone.version as 2.48.0 in google-cloud-pom-parent, matching the version in gapic-generator-java-pom-parent. Remove local overrides from java-bigtable and java-datastore so they inherit the version from the parent. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Update Error Prone references in java-bigtable and java-datastore to use the version and arguments defined in google-cloud-pom-parent. This resolves compilation issues on JDK 26 while maintaining compatibility with older JDK versions via profiles in the parent POM. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Fix compilation errors triggered by the new Error Prone version. - Update DatastoreHelper to avoid Iterators.getNext(..., null). - Update Bigtable tests to use isNull() instead of isEqualTo(null). - Update Bigtable tests to use lambda instead of Suppliers.ofInstance(null). - Suppress NullArgumentForNonNullParameter for SettableFuture<Void> set(null) calls. - Rewrite VRpcResultSubject to avoid passing null to Truth's that() directly. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
- Rename profiles in google-cloud-pom-parent for clarity: - jdk-old -> errorprone-jdk11 - jdk-mid -> errorprone-jdk17 - Add comments explaining Error Prone downgrades and compiler flags. - Reformat EnvInfoTest.java to comply with style guide. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Remove tautological assertThat(f.get()).isNull() assertions on ApiFuture<Void> instances where f.get() normal completion is already evaluated lines earlier. This cleanly resolves Error Prone NullArgumentForNonNullParameter warnings without adding @SuppressWarnings annotations. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Rename Iterator<Entity> temporary variable in DatastoreHelper.get() from misleading "limit" to "results" based on PR review feedback. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Restore assertThat(f.get()).isNull() assertions in EnhancedBigtableStubTest based on PR review feedback to explicitly document asynchronous future completion. Add @SuppressWarnings("NullArgumentForNonNullParameter") annotations to resolve Error Prone warnings triggered by Truth.assertThat() receiving an ApiFuture<Void> result. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
- Drop legacy Error Prone downgrade profiles (errorprone-jdk11, errorprone-jdk17) as Error Prone 2.43.0+ requires JDK 21+ execution. - Scope `-XDaddTypeAnnotationsToSymbol=true` strictly to JDK 21 execution via dedicated `errorprone-jdk21` profile, setting default javac arg to benign `-g`. On JDK 22+ (including 25 and 26), the Javac fix is enabled by default. Ref: google/error-prone#5426 BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Restore downgrade profiles (`errorprone-jdk11`, `errorprone-jdk17`) in parent POM to ensure builds executed on older Javac compilers (JDK 8, 11, 17) use compatible Error Prone versions (`2.38.0`, `2.42.0`). BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Add comprehensive comments explaining the necessity of legacy Error Prone version downgrades (`2.38.0`, `2.42.0`) for Java 8+ build compatibility. Clarify that `-XDaddTypeAnnotationsToSymbol=true` is scoped specifically to JDK 21 execution per Error Prone Issue #5426 and is omitted on JDK 22+ where the attribution fix is enabled natively by default. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Remove outdated comment referencing unmanaged Error Prone Core synchronization in `java-datastore/pom.xml`, as the version is now centrally managed by the top-level parent POM. Ref: https://github.com/googleapis/java-datastore/issues/1889 BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
…tSubject Inline `retryInfo.getRetryDelay()` calls within `retryInfoDelay()` subject assertion to avoid fully qualified `com.google.protobuf.Duration` class reference per PR review. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
Use CopyOnWriteArrayList instead of ArrayList in FakeBigtableService mock implementation. The mock service receives gRPC requests on gRPC executor threads and adds them to openSessionRequests and vrpcRequests. The test thread reads these lists to verify client payloads. Without proper thread synchronization, visibility and ordering issues can cause the test thread to read a null element during ArrayList.add, resulting in a NullPointerException in testMaterializedViewRequestSent. BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
…ava versions - Update OS matrix to latest versions: ubuntu-24.04, windows-2025, macos-15 (ARM64) - Expand Java matrix to include missing LTS versions (21, 25) and latest JDK 26 BUG=b/481669998 TAG=agy CONV=7b193e4d-38f8-450c-8475-0b9ae0d04507
lqiu96
force-pushed
the
add-jdk-26-support
branch
from
88c4fb6 to
90d0a41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JDK 26 to build matrices in GitHub Actions workflows. Update Bazel integration tests in sdk-platform-java to run on JDK 25 and 26 with Security Manager override.
High Level Changes
BigTable and Datastore Changes Due to ErrorProne
Datastore
BigTable