Skip to content

MDEV-25727 Add FORMAT JSON support to JSON_TABLE#4744

Merged
grooverdan merged 2 commits into
MariaDB:mainfrom
varundeepsaini:MDEV-25727-format-json-table
Jun 11, 2026
Merged

MDEV-25727 Add FORMAT JSON support to JSON_TABLE#4744
grooverdan merged 2 commits into
MariaDB:mainfrom
varundeepsaini:MDEV-25727-format-json-table

Conversation

@varundeepsaini

@varundeepsaini varundeepsaini commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add explicit FORMAT JSON support to JSON_TABLE columns
  • preserve explicit FORMAT JSON in view printing
  • add regression coverage for formatted extraction and unsupported targets

Testing

  • clean out-of-source minbuild
  • json.json_table_mysql

Tests written by Claude

@varundeepsaini varundeepsaini marked this pull request as draft March 6, 2026 10:51
@varundeepsaini varundeepsaini force-pushed the MDEV-25727-format-json-table branch 2 times, most recently from e2b238a to 8b1b7bc Compare March 6, 2026 17:46
@varundeepsaini varundeepsaini marked this pull request as ready for review March 6, 2026 18:41
@gkodinov gkodinov added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Mar 9, 2026

@gkodinov gkodinov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This is a preliminary review.

LGTM! Very clean!

Stand by for the final review please.

@CLAassistant

CLAassistant commented Mar 30, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@varundeepsaini varundeepsaini force-pushed the MDEV-25727-format-json-table branch from 8b1b7bc to fcb6972 Compare April 1, 2026 11:50

@mariadb-RuchaDeodhar mariadb-RuchaDeodhar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address that one comment. Otherwise looks ok to push. Thanks !

Comment thread sql/json_table.h
Allow explicit FORMAT JSON columns in JSON_TABLE for supported
string, blob, and JSON targets.

Preserve the explicit clause in view printing and add regression
coverage for formatted extraction, unsupported targets, and SHOW
CREATE VIEW.

Signed-off-by: Varun Deep Saini <[email protected]>
Signed-off-by: Varun Deep Saini <[email protected]>
@varundeepsaini varundeepsaini force-pushed the MDEV-25727-format-json-table branch from ba056f1 to 6130b18 Compare April 25, 2026 16:28
@gkodinov gkodinov requested a review from elenst April 28, 2026 15:25
@grooverdan grooverdan merged commit c3ec2dc into MariaDB:main Jun 11, 2026
17 of 20 checks passed
@grooverdan

Copy link
Copy Markdown
Member

Thank you @varundeepsaini !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.

Development

Successfully merging this pull request may close these issues.

6 participants