chore: add test to document current behaviour on template ACL revocation#26104
Open
johnstcn wants to merge 4 commits into
Open
chore: add test to document current behaviour on template ACL revocation#26104johnstcn wants to merge 4 commits into
johnstcn wants to merge 4 commits into
Conversation
Docs preview📖 View docs preview for |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds coverage and admin-facing documentation for the current behavior when a user loses access to a template after creating a workspace from it (template RBAC/ACL revocation), clarifying that subsequent workspace build transitions fail.
Changes:
- Added an enterprise integration test that revoking template access prevents starting an existing workspace build.
- Added a warning to the template permissions admin docs describing the operational impact of removing template access.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| enterprise/coderd/workspacebuilds_test.go | Adds a regression/documentation test for workspace build behavior after template access is revoked. |
| docs/admin/templates/template-permissions.md | Documents the impact of losing template access on managing existing workspaces. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents a question raised in #26061 (comment) - I couldn't find the exact answer, so adding a test and accompanying documentation seemed like the prudent move here.