Skip to content

Fix typo changable > changeable#4968

Merged
DedeHai merged 1 commit into
wled:mainfrom
MathijsG:patch-1
Sep 28, 2025
Merged

Fix typo changable > changeable#4968
DedeHai merged 1 commit into
wled:mainfrom
MathijsG:patch-1

Conversation

@MathijsG

@MathijsG MathijsG commented Sep 28, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Fix typo that I discovered while tinkering in Wled.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a typographical error in the OTA lock description within the Security settings, changing “changable” to “changeable.”
    • Text-only update; no functional changes or impact on existing configurations or workflows.
    • Improves clarity and polish in user-facing copy.
    • Visible wherever the OTA lock guidance is shown in the interface.

@MathijsG
Fix typo changable > changeable
f096320 
Fix typo that I discovered while tinkering in Wled.
@coderabbitai

coderabbitai Bot commented Sep 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

A single UI text correction in wled00/data/settings_sec.htm updates the OTA lock description, changing “changable” to “changeable.” No logic, behavior, or structural code changes were made.

Changes

Cohort / File(s) Summary
UI text correction
wled00/data/settings_sec.htm		 Fixed typo in OTA lock description: "changable" → "changeable"; no functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely describes the specific typo correction from “changable” to “changeable”, directly reflecting the main change without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e23751b and f096320.

📒 Files selected for processing (1)
  • wled00/data/settings_sec.htm (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
wled00/data/**/*.{htm,html,css,js}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use tabs for indentation in web files (.htm/.html/.css/.js) under wled00/data

Files:

  • wled00/data/settings_sec.htm
🧠 Learnings (2)
📓 Common learnings 
Learnt from: DedeHai
PR: wled/WLED#4923
File: wled00/FX.cpp:4883-4901
Timestamp: 2025-09-12T17:29:43.826Z
Learning: In WLED’s web UI, only one slider value (e.g., SEGMENT.intensity or SEGMENT.custom1) changes at a time; code relying on this may use simplified change guards, though presets/JSON can still update multiple fields atomically.
📚 Learning: 2025-05-26T16:09:34.325Z 
Learnt from: blazoncek
PR: wled/WLED#4700
File: wled00/wled_server.cpp:409-414
Timestamp: 2025-05-26T16:09:34.325Z
Learning: In wled00/wled_server.cpp, the OTA update access control logic intentionally allows OTA updates from different subnets when otaSameSubnet is true AND a PIN is set. This was a conscious design decision by blazoncek to provide flexibility for remote OTA updates with PIN protection, though they acknowledged it may not be the optimal security model.

Applied to files:

  • wled00/data/settings_sec.htm
🔇 Additional comments (1)
wled00/data/settings_sec.htm (1)

51-51: Typo fix looks good

Thanks for correcting the spelling; the updated copy is clear and consistent with the rest of the UI text.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DedeHai

DedeHai commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

thanks!

@DedeHai DedeHai merged commit d86ae7d into wled:main Sep 28, 2025
@MathijsG MathijsG deleted the patch-1 branch September 28, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MathijsG @DedeHai