libhb: move filters out of decavcodec.c#7658
Draft
galad87 wants to merge 1 commit into
Draft
Conversation
Contributor
|
@galad87 I'm sorry to inform you, that I parted ways with Intel and don't have the resources currently to contribute :( |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the filters used to handle the video changing format/size/rotation/range mid stream outside of decavcodec.c, to a filter chain inside the main filter chain.
It's cleaner, we won't have to maintain two different sets of filters, and it will make it possible in the future to avoid running the same filter twice when the source is not interlaced, and to run hardware filters in additional places.
@antonkesy could you check why VPP is failing with an "Error running VPP: undefined behavior (-16) when I run:
./HandBrakeCLI.exe -I size-changes.mp4 --preset "Hardware/H.265 QSV 1080p" --enable-hw-decoding qsv -o output.mp4
with this cursed file https://www.swisstransfer.com/d/02460563-65a5-4667-9599-9c28249ac580
VPP has been flaky even before this PR, so it would be nice if you could take a look.
Tested on: