feat: modules & html viewer dynamic height#16807
Open
shaurya-sharma064 wants to merge 3 commits into
Open
Conversation
…moduleViewer This update introduces new properties for dynamic height and collapse when hidden in both moduleContainer and moduleViewer configurations. Additionally, the appCanvasUtils has been enhanced to support these properties, ensuring that the instance defaults are correctly applied. The WidgetWrapper has also been updated to include 'ModuleViewer' in the dynamic height auto list. This change improves the flexibility and usability of the module components.
shaurya-sharma064
requested review from
johnsoncherian and
kavinvenkatachalam
as code owners
❌ Deploy Preview for storybook-tooljet failed.
|
shaurya-sharma064
changed the base branch from
lts-3.16
to
perf/store-batching-lts
Co-Authored-By: Claude Fable 5 <[email protected]>
shaurya-sharma064
changed the title
…namic height handling This update modifies the dynamic height reflow mechanism by replacing the adjustComponentPositions function with scheduleReflow, which batches reflow requests for improved performance. The changes are reflected across multiple components, including RenderWidget and ModalV2, enhancing the efficiency of layout adjustments during widget size changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/ToolJet/tj-ee/issues/5166, https://github.com/ToolJet/tj-ee/issues/5180