You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] CODEMOD_REGISTRY_URL is no longer honored for default registry when config.json is missing
load_config_with_env now falls back to a hardcoded production URL when no config file exists and no explicit env map is passed. TokenStorage::load_config() always calls this with None, and that method is used by non-feedback flows (publish, login, whoami, telemetry init, etc.). As a result, on a fresh setup CODEMOD_REGISTRY_URL no longer changes the default registry for those commands, whereas previously this worked via RegistryConfig::default(). This is a behavioral regression that can break staging/self-hosted workflows (especially publish, which has no --registry flag). The env-insensitive behavior should be scoped to feedback-consent persistence instead of changing the global fallback.
Fails only when candidate median is more than 25% slower and exceeds the benchmark-specific absolute floor.
TUI Perf Comparison
Baseline dir: perf-results/baseline
Candidate dir: perf-results/candidate
Completed
Metric
Baseline
Candidate
Delta
deadline_wakeups
1
1
0
draws
1
1
0
Awaiting Trigger
Metric
Baseline
Candidate
Delta
deadline_wakeups
1
1
0
draws
1
1
0
Active
Metric
Baseline
Candidate
Delta
deadline_wakeups
4
4
0
draws
4
4
0
Awaiting Trigger Resume
Metric
Baseline
Candidate
Delta
deadline_wakeups
1
1
0
draws
1
1
0
Active Busy
Metric
Baseline
Candidate
Delta
deadline_wakeups
4
4
0
draws
4
4
0
Terminal Activity
Metric
Baseline
Candidate
Delta
deadline_wakeups
1
1
0
draws
3
3
0
terminal_events
2
2
0
terminal_key_events
1
1
0
terminal_resize_events
1
1
0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
📚 Description
Fixes the anonymous feedback consent path so it does not persist
CODEMOD_REGISTRY_URLinto the user-widedefault_registrysetting.RegistryConfig::default().CODEMOD_REGISTRY_URLavailable as a runtime-only endpoint override for feedback submission.🔗 Linked Issue
Fixes CDMD-4787
🧪 Test Plan
cargo test -p codemod auth::storage::tests::enable_anonymous_feedback_does_not_persist_registry_env_override -- --exactcargo test -p codemod feedback::tests::env_registry_url_trims_and_ignores_empty_values -- --exactcargo check -p codemod --bin codemodoxlint,oxfmt --check📄 Documentation to Update
No documentation changes needed. This preserves the documented registry behavior while fixing config persistence.