fix: refresh dev commands when enabling developer mode#12765
Open
megayu wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures developer-only shortcut commands are refreshed when developer mode is toggled, so the command palette reflects the current developer-mode state instead of being effectively “snapshotted” at initial config build time.
Changes:
- Allow shortcut entries’
:inactiveto be a zero-arity predicate (not just a boolean), enabling dynamic gating on developer mode. - Refactor shortcut config construction into
build-config+rebuild-config!, and invoke rebuild + command re-registration when developer mode is toggled in Settings. - Add a frontend test asserting dev shortcuts are excluded/included depending on developer mode.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/test/frontend/modules/shortcut/config_test.cljs |
Adds coverage for dev shortcuts presence/absence based on developer mode. |
src/main/frontend/modules/shortcut/config.cljs |
Supports predicate-based :inactive; introduces build-config and rebuild-config! to rebuild shortcut config. |
src/main/frontend/handler/command_palette.cljs |
Adds a “refresh” path for global shortcut-derived command palette entries. |
src/main/frontend/components/settings.cljs |
Rebuilds shortcut config and refreshes global shortcut commands when toggling developer mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.