chore: use shared renovate config#96
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines dependency management by adopting a centralized Renovate configuration. This change replaces a custom, detailed local setup with a single reference to a shared preset, aiming to standardize and simplify how dependencies are updated across projects. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration to use a shared preset, which is a good practice for standardizing dependency management. The change is straightforward and replaces the local configuration with a reference to a shared one. I have reviewed the changes and found no issues.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Renovate configuration to rely on a shared preset (github>rstackjs/renovate) instead of locally defined rules, aiming to centralize and standardize dependency update behavior.
Changes:
- Replaces the local Renovate
extendslist with a shared preset reference. - Removes locally defined
rangeStrategyandpackageRules(peerDependencies disabled).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| extends: ['config:base', 'schedule:monthly', 'group:allNonMajor'], | ||
| rangeStrategy: 'bump', | ||
| packageRules: [{ depTypeList: ['peerDependencies'], enabled: false }], | ||
| extends: ['github>rstackjs/renovate'], |
There was a problem hiding this comment.
Using extends: ['github>rstackjs/renovate'] without a ref/tag means the effective Renovate config can change whenever that repo updates, which can unexpectedly alter dependency update behavior in this repo. Consider pinning the preset to a specific tag/commit (and updating intentionally) to make Renovate behavior reproducible.
| extends: ['github>rstackjs/renovate'], | |
| extends: ['github>rstackjs/renovate#1.0.0'], |
| extends: ['config:base', 'schedule:monthly', 'group:allNonMajor'], | ||
| rangeStrategy: 'bump', | ||
| packageRules: [{ depTypeList: ['peerDependencies'], enabled: false }], | ||
| extends: ['github>rstackjs/renovate'], |
There was a problem hiding this comment.
Switching to the shared preset removes the previously explicit settings (monthly schedule, grouping all non-major, rangeStrategy=bump, and disabling peerDependencies updates). If the shared preset doesn’t include equivalent rules, Renovate behavior will change (e.g., peerDependencies PRs may start appearing). Consider either confirming the preset matches these behaviors or re-adding local overrides for any repo-specific requirements.
| extends: ['github>rstackjs/renovate'], | |
| extends: ['github>rstackjs/renovate'], | |
| // Run Renovate on a monthly schedule | |
| schedule: ['before 5am on the first day of the month'], | |
| // Local package rules to preserve previous behavior | |
| packageRules: [ | |
| { | |
| // Group all non-major dependency updates together | |
| matchUpdateTypes: ['minor', 'patch'], | |
| groupName: 'all non-major dependencies', | |
| groupSlug: 'all-non-major', | |
| rangeStrategy: 'bump', | |
| }, | |
| { | |
| // Disable updates to peerDependencies | |
| matchDepTypes: ['peerDependencies'], | |
| enabled: false, | |
| }, | |
| ], |
This pull request updates the Renovate configuration to use a shared configuration preset, simplifying and standardizing dependency management settings.